Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equals and hashCode of ActivationHistoryEntity #1119

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Fix equals and hashCode of ActivationHistoryEntity #1119

merged 6 commits into from
Nov 9, 2023

Conversation

banterCZ
Copy link
Member

@banterCZ banterCZ commented Nov 8, 2023

A follow-up to #1107

romanstrobl
romanstrobl requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, but still incorrect. We should include fields which identify the entity into the equals and hashCode contract, not various parameters such as reason why activation was blocked, that does not correspond to the identity of the entity.

@banterCZ banterCZ requested a review from romanstrobl November 8, 2023 14:20
romanstrobl
romanstrobl requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect method name.

.../io/getlime/security/powerauth/app/server/database/model/entity/ActivationHistoryEntity.java Outdated Show resolved Hide resolved
@banterCZ banterCZ requested a review from romanstrobl November 9, 2023 07:14
romanstrobl
romanstrobl approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for your patience.

@banterCZ banterCZ merged commit 5c3b4d0 into develop Nov 9, 2023
5 checks passed
@banterCZ banterCZ deleted the issues/1107-activation-history-equals branch November 9, 2023 09:34
banterCZ added a commit that referenced this pull request Nov 9, 2023
@banterCZ
Fix equals and hashCode of ActivationHistoryEntity (#1119)
0e524e4 
* Fix equals and hashCode of ActivationHistoryEntity

A follow-up to #1107

(cherry picked from commit 5c3b4d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanstrobl romanstrobl romanstrobl approved these changes

@zcgandcomp zcgandcomp Awaiting requested review from zcgandcomp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banterCZ @romanstrobl