Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1107: Update activation name (backport) #1118

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Fix #1107: Update activation name (backport) #1118

merged 2 commits into from
Nov 9, 2023

Conversation

banterCZ
Copy link
Member

@banterCZ banterCZ commented Nov 8, 2023

  • add activation name into history

(cherry picked from commit a10c77f)

@banterCZ
Fix #1107: Update activation name (#1109)
aeb592e 
* Fix #1107: Update activation name

- add activation name into history

(cherry picked from commit a10c77f)
romanstrobl
romanstrobl requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use ID comparison in equals for entities with auto-generated IDs.

.../io/getlime/security/powerauth/app/server/database/model/entity/ActivationHistoryEntity.java Outdated Show resolved Hide resolved
@banterCZ
Fix equals and hashCode of ActivationHistoryEntity (#1119)
0e524e4 
* Fix equals and hashCode of ActivationHistoryEntity

A follow-up to #1107

(cherry picked from commit 5c3b4d0)
@banterCZ banterCZ requested a review from romanstrobl November 9, 2023 10:02
romanstrobl
romanstrobl approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@banterCZ banterCZ merged commit d46fa95 into releases/1.5.x Nov 9, 2023
5 checks passed
@banterCZ banterCZ deleted the issues/1107-update-activation-name branch November 9, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanstrobl romanstrobl romanstrobl approved these changes

@zcgandcomp zcgandcomp Awaiting requested review from zcgandcomp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banterCZ @romanstrobl