Skip to content

Commit

Permalink
Fix #1314: FIDO2: Add new signature types (#1356)
Browse files Browse the repository at this point in the history
* Fix #1314: FIDO2: Add new signature types

* Fix comments from the code review
  • Loading branch information
petrdvorak authored Mar 4, 2024
1 parent e5eb8a0 commit 8863190
Show file tree
Hide file tree
Showing 6 changed files with 303 additions and 220 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
package com.wultra.powerauth.fido2.rest.model.converter;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.wultra.powerauth.fido2.rest.model.entity.AaguidList;
import com.wultra.powerauth.fido2.rest.model.entity.Fido2Authenticators;
import com.wultra.powerauth.fido2.rest.model.entity.AuthenticatorDetail;
import com.wultra.powerauth.fido2.rest.model.entity.AuthenticatorParameters;
import com.wultra.powerauth.fido2.rest.model.entity.RegistrationChallenge;
Expand Down Expand Up @@ -58,11 +58,13 @@ public Optional<AuthenticatorDetail> convert(RegistrationChallenge challenge, Re
authenticatorDetail.setActivationId(challenge.getActivationId());
authenticatorDetail.setApplicationId(challenge.getApplicationId());

final Fido2Authenticators.Model model = Fido2Authenticators.modelByAaguid(aaguid);

authenticatorDetail.setExternalId(requestObject.getAuthenticatorParameters().getId());
authenticatorDetail.setExtras(convertExtras(requestObject));
authenticatorDetail.setActivationName(requestObject.getActivationName());
authenticatorDetail.setPlatform(requestObject.getAuthenticatorParameters().getAuthenticatorAttachment());
authenticatorDetail.setDeviceInfo(AaguidList.vendorName(aaguid));
authenticatorDetail.setDeviceInfo(model.description());
authenticatorDetail.setActivationStatus(ActivationStatus.ACTIVE);
authenticatorDetail.setActivationFlags(new ArrayList<>());
authenticatorDetail.setApplicationRoles(new ArrayList<>());
Expand Down

This file was deleted.

Loading

0 comments on commit 8863190

Please sign in to comment.