Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed serialAll option from concurrency settings #63

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Removed serialAll option from concurrency settings #63

merged 5 commits into from
Jul 8, 2024

Conversation

kober32
Copy link
Member

@kober32 kober32 commented Jul 6, 2024

Resolved #62

  • Removed serialAll concurrency option which could cause deadlock and other unexpected behaviors.
  • Improved inline documentation.
  • Fixed typo in concurrent word.

Shall be released as 1.4.

@kober32 kober32 requested a review from Hopsaheysa July 6, 2024 06:07
Hopsaheysa
Hopsaheysa approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@Hopsaheysa Hopsaheysa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok 👍

@kober32 kober32 merged commit fa81ba4 into develop Jul 8, 2024
2 checks passed
@kober32 kober32 deleted the issues/62-deadlock-fix branch July 8, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hopsaheysa Hopsaheysa Hopsaheysa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix serialization issue
2 participants
@kober32 @Hopsaheysa