Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed attribute deserialization #141

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Conversation

Hopsaheysa
Copy link
Member

When deserialisation of one attribute fails it is not completely interrupted but proceeds to deserialise the rest of the data

kober32
kober32 previously approved these changes Jan 12, 2024
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 A test for it would be nice :)

Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Condition of the test can be improved.

WultraMobileTokenSDKTests/NetworkingObjectsTests.swift Outdated Show resolved Hide resolved
@Hopsaheysa Hopsaheysa requested a review from kober32 January 12, 2024 16:42
kober32
kober32 previously approved these changes Jan 15, 2024
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works OK but the conditions can be simplified a lot.

WultraMobileTokenSDKTests/NetworkingObjectsTests.swift Outdated Show resolved Hide resolved
WultraMobileTokenSDKTests/NetworkingObjectsTests.swift Outdated Show resolved Hide resolved
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hopsaheysa Hopsaheysa merged commit 4397eef into develop Jan 16, 2024
4 checks passed
@Hopsaheysa Hopsaheysa deleted the attribute-deserialization branch January 16, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants