Fix #904: Add parsed user agent to the audit #909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banterCZ
approved these changes
Nov 13, 2023
| @@ -200,6 +205,10 @@ public void operationFailApprove(@NotNull String operationId, @NotNull RequestCo | |||
| // Prepare additional data | |||
| request.getAdditionalData().put(ATTR_IP_ADDRESS, requestContext.getIpAddress()); | |||
| request.getAdditionalData().put(ATTR_USER_AGENT, requestContext.getUserAgent()); | |||
| final UserAgent.Device device = UserAgent.parse(requestContext.getUserAgent()); | |||
There was a problem hiding this comment.
Out of the scope of this PR, but UserAgent.parse is missing Javadoc, and instead of null it could return Optional.
|
It has been decided in #904, that no changes in ES need to be made. Therefore, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected PRs that need to be merged first:
wultra/lime-java-core#227
wultra/powerauth-server#1125