pull from devel to master to create release 68.7.0 #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules for running the tag_metrics and spacial_filter checks made more explicit.
And explained the logic.
Changed the signature of _should_run from ($is_plex, $product) to ($product, $is_lane, $is_plex), so that $is_lane flag is set by the caller. Previously it was assumed that anything that is not a plex is a lane. This is wrong for merged lanes, for which some lane- level checks cannot run, for example spacial_filter, tag_metrics.
Simpifies autoqc function code and allows for lane-level review autoqc
* Move from Miniconda to Miniforge * Move from Miniconda to Miniforge
prep release 68.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.