Merge pull request #826 from jmtcsngr/drop_s3_archival

Update s3 code documentation, log cofiguration and drop script for checking receipts before deletion

MANIFEST

@@ -9,7 +9,6 @@ bin/npg_pipeline_post_qc_review
 bin/npg_pipeline_preexec_references
 bin/npg_pipeline_script_must_be_unique_runner
 bin/npg_pipeline_seqchksum_comparator
-bin/npg_receipt4run_is_deletable
 bin/npg_run_is_deletable
 Build.PL
 Changes

bin/npg_run_is_deletable

@@ -19,7 +19,6 @@ my $their_log_level = $verbose ? 'DEBUG' : 'WARN';
 ##no critic (ValuesAndExpressions::ProhibitImplicitNewlines)
 my $log4perl_config = qq(
   log4perl.logger                                  = $my_log_level, A1
-  log4perl.category.npg_pipeline.validation.s3     = $their_log_level, A1
   log4perl.category.npg_pipeline.validation.irods  = $their_log_level, A1
   log4perl.category.npg_pipeline.validation.autoqc = $their_log_level, A1
   log4perl.logger.WTSI.NPG.iRODS                   = OFF, A1

lib/npg_pipeline/product/release.pm

@@ -106,7 +106,6 @@ sub is_release_data {
   Arg [2]    : Str, type of release
 
   Example    : $obj->is_for_release($product, 'irods');
-               $obj->is_for_release($product, 's3');
   Description: Return true if the product is to be released via the
                mechanism defined by the second argument.
 
@@ -376,35 +375,22 @@ product release.
 The configuration file gives per-study settings and a default to be
 used for any study without a specific configuration.
 
- S3:
-    enable: <boolean> S3 release enabled if true.
-    url:    <URL>     The S3 bucket URL to send to.
-
  irods:
     enable: <boolean> iRODS release enabled if true.
 
 e.g.
 
 ---
 default:
-  s3:
-    enable: false
-    url: null
   irods:
     enable: true
 
 study:
   - study_id: "5290"
-    s3:
-      enable: true
-      url: "s3://product_bucket"
     irods:
       enable: false
 
   - study_id: "1000"
-    s3:
-      enable: false
-      url: null
     irods:
       enable: true