Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /resend-pending-builds endpoint #48

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

sersorrel
Copy link
Member

This endpoint finds all "pending" builds (not yet successful/failed) and resends them to the builder.

Additionally, queue environments for creation even when the builder is unavailable (because it might come back up later and ask for them).

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (16e49df) 65.29% compared to head (e2819fa) 61.83%.
Report is 11 commits behind head on develop.

Files Patch % Lines
softpack_core/service.py 26.31% 14 Missing ⚠️
softpack_core/schemas/environment.py 13.33% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #48      +/-   ##
===========================================
- Coverage    65.29%   61.83%   -3.46%     
===========================================
  Files           16       17       +1     
  Lines          775      896     +121     
  Branches       131      163      +32     
===========================================
+ Hits           506      554      +48     
- Misses         262      335      +73     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sb10 sb10 force-pushed the resend-pending-builds branch from af63546 to e2819fa Compare February 22, 2024 16:19
@sb10 sb10 merged commit c610828 into develop Feb 22, 2024
3 of 5 checks passed
@sb10 sb10 deleted the resend-pending-builds branch February 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants