Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate environment paths #44

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Validate environment paths #44

merged 1 commit into from
Feb 7, 2024

Conversation

sersorrel
Copy link
Member

to avoid breaking the world if someone creates an environment called users/not-a-username

@sersorrel sersorrel requested review from sb10 and mjkw31 February 7, 2024 10:08
@sersorrel sersorrel requested a review from altaf-ali as a code owner February 7, 2024 10:08
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (16e49df) 65.29% compared to head (d934932) 64.96%.
Report is 7 commits behind head on develop.

Files Patch % Lines
softpack_core/schemas/environment.py 23.68% 29 Missing ⚠️
softpack_core/artifacts.py 76.92% 3 Missing ⚠️
softpack_core/schemas/groups.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #44      +/-   ##
===========================================
- Coverage    65.29%   64.96%   -0.33%     
===========================================
  Files           16       17       +1     
  Lines          775      822      +47     
  Branches       131      143      +12     
===========================================
+ Hits           506      534      +28     
- Misses         262      281      +19     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sb10 sb10 merged commit 17c5908 into develop Feb 7, 2024
3 of 5 checks passed
@sb10 sb10 deleted the path-validation branch February 7, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants