Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten GraphQL definition of environment type #43

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

sersorrel
Copy link
Member

This is already assumed to be the case by the frontend.

Also document how to generate a GraphQL .schema file, which can be used by the frontend for type-checking.

@sersorrel sersorrel requested review from sb10 and mjkw31 February 7, 2024 09:24
@sersorrel sersorrel requested a review from altaf-ali as a code owner February 7, 2024 09:24
Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (16e49df) 65.29% compared to head (8ce9ddb) 65.28%.
Report is 6 commits behind head on develop.

Files Patch % Lines
softpack_core/schemas/environment.py 29.03% 22 Missing ⚠️
softpack_core/artifacts.py 76.92% 3 Missing ⚠️
softpack_core/schemas/groups.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
- Coverage    65.29%   65.28%   -0.01%     
===========================================
  Files           16       17       +1     
  Lines          775      818      +43     
  Branches       131      141      +10     
===========================================
+ Hits           506      534      +28     
- Misses         262      277      +15     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sb10 sb10 merged commit 08aaae2 into develop Feb 7, 2024
3 of 5 checks passed
@sb10 sb10 deleted the schema-tightening branch February 7, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants