Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current time as commit timestamp #42

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Use current time as commit timestamp #42

merged 5 commits into from
Feb 6, 2024

Conversation

sersorrel
Copy link
Member

also, fix previously-broken integration tests: Environment.create() now mutates its input.

Environment.create() now mutates its input.
(rather than the time the server started up)
@sersorrel sersorrel requested review from sb10 and mjkw31 February 6, 2024 11:50
@sersorrel sersorrel requested a review from altaf-ali as a code owner February 6, 2024 11:50
mjkw31
mjkw31 previously approved these changes Feb 6, 2024
Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ff0dde7) 65.19% compared to head (5e6cb29) 65.11%.

❗ Current head 5e6cb29 differs from pull request most recent head a9cbb3b. Consider uploading reports for the commit a9cbb3b to get more accurate results

Files Patch % Lines
softpack_core/artifacts.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
- Coverage    65.19%   65.11%   -0.09%     
===========================================
  Files           17       17              
  Lines          813      814       +1     
  Branches       139      140       +1     
===========================================
  Hits           530      530              
- Misses         276      277       +1     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sb10
sb10 previously approved these changes Feb 6, 2024
mjkw31
mjkw31 previously approved these changes Feb 6, 2024
@sersorrel sersorrel dismissed stale reviews from mjkw31 and sb10 via bc2d156 February 6, 2024 14:40
@sb10 sb10 merged commit ddb696e into develop Feb 6, 2024
3 checks passed
@sb10 sb10 deleted the commit-timestamps branch February 6, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants