Clean up environments that couldn't be scheduled #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sersorrel
requested review from
mjkw31 and
sb10
and removed request for
altaf-ali
Fixes: Ign:10 http://azure.archive.ubuntu.com/ubuntu focal-updates/main amd64 libldap2-dev amd64 2.4.49+dfsg-2ubuntu1.9 Ign:10 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libldap2-dev amd64 2.4.49+dfsg-2ubuntu1.9 Ign:10 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libldap2-dev amd64 2.4.49+dfsg-2ubuntu1.9 Err:10 mirror+file:/etc/apt/apt-mirrors.txt focal-updates/main amd64 libldap2-dev amd64 2.4.49+dfsg-2ubuntu1.9 404 Not Found [IP: 52.252.163.49 80] E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/o/openldap/libldap2-dev_2.4.49+dfsg-2ubuntu1.9_amd64.deb 404 Not Found [IP: 52.252.163.49 80] E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #41 +/- ##
===========================================
- Coverage 65.31% 65.19% -0.13%
===========================================
Files 17 17
Lines 816 813 -3
Branches 139 139
===========================================
- Hits 533 530 -3
Misses 276 276
Partials 7 7 ☔ View full report in Codecov by Sentry. |
sb10
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After wtsi-hgi/softpack-web#55, nothing will use
id, and it's badly-named (or at least underdocumented) and doesn't seem useful, so let's remove it.Additionally, environments whose build could not be scheduled (the builder wasn't available, or returned an error) are now cleaned up.
Lastly, add a test to prove to ourselves that there's no (or a very low) chance of a race condition when making multiple commits simultaneously. (And even when adding a random delay in the middle of
commit_and_pushto make a race condition more likely, pygit2 caught the problem and raised an exception.)