Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow spaces and other troublesome characters in environment names #40

Merged
merged 4 commits into from
Jan 31, 2024

Update docs for EnvironmentInput.validate

6265386
Select commit
Loading
Failed to load commit list.
Merged

Disallow spaces and other troublesome characters in environment names #40

Update docs for EnvironmentInput.validate
6265386
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 31, 2024 in 0s

65.31% (+0.02%) compared to 16e49df

View this Pull Request on Codecov

65.31% (+0.02%) compared to 16e49df

Details

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (16e49df) 65.29% compared to head (6265386) 65.31%.
Report is 3 commits behind head on develop.

Files Patch % Lines
softpack_core/schemas/environment.py 28.00% 18 Missing ⚠️
softpack_core/artifacts.py 50.00% 2 Missing ⚠️
softpack_core/schemas/groups.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #40      +/-   ##
===========================================
+ Coverage    65.29%   65.31%   +0.02%     
===========================================
  Files           16       17       +1     
  Lines          775      816      +41     
  Branches       131      139       +8     
===========================================
+ Hits           506      533      +27     
- Misses         262      276      +14     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.