-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-service building (backend pieces) #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that the frontend can display a list of folders they can put a new environment in
Converting an exception to a string just extracts the message – you don't get to see what type the exception was, which is critical.
This is required for the server to efficiently restart on file changes.
with `strawberry export-schema softpack_core.graphql:GraphQL.schema`
mjkw31
previously approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
sb10
requested changes
Jan 29, 2024
Our typeshed definitions are out of date!
Closes #34
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #39 +/- ##
===========================================
+ Coverage 65.29% 65.51% +0.22%
===========================================
Files 16 17 +1
Lines 775 809 +34
Branches 131 137 +6
===========================================
+ Hits 506 530 +24
- Misses 262 272 +10
Partials 7 7 ☔ View full report in Codecov by Sentry. |
This isn't used for anything??
sb10
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
softpack.yml
as soon as the build is scheduled, so that the build shows up in the frontend in a "queued" state (with all details known at the time)