Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-service building (backend pieces) #39

Merged
merged 14 commits into from
Jan 29, 2024
Merged

Self-service building (backend pieces) #39

merged 14 commits into from
Jan 29, 2024

Conversation

sersorrel
Copy link
Member

  • fix the API call to the builder used to schedule environment builds (now includes the package versions)
  • allow the builder URL to be changed in config
  • opportunistically create a softpack.yml as soon as the build is scheduled, so that the build shows up in the frontend in a "queued" state (with all details known at the time)
  • add an API to fetch a user's LDAP groups, so the frontend can display an appropriate list of folders to create environments in

so that the frontend can display a list of folders they can put a new
environment in
Converting an exception to a string just extracts the message – you
don't get to see what type the exception was, which is critical.
This is required for the server to efficiently restart on file changes.
with `strawberry export-schema softpack_core.graphql:GraphQL.schema`
@sersorrel sersorrel requested review from sb10 and mjkw31 January 26, 2024 11:37
@sersorrel sersorrel requested a review from altaf-ali as a code owner January 26, 2024 11:37
mjkw31
mjkw31 previously approved these changes Jan 26, 2024
Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tests/integration/test_groups.py Outdated Show resolved Hide resolved
tests/integration/test_groups.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (16e49df) 65.29% compared to head (973875d) 65.51%.
Report is 2 commits behind head on develop.

Files Patch % Lines
softpack_core/schemas/environment.py 29.41% 12 Missing ⚠️
softpack_core/schemas/groups.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #39      +/-   ##
===========================================
+ Coverage    65.29%   65.51%   +0.22%     
===========================================
  Files           16       17       +1     
  Lines          775      809      +34     
  Branches       131      137       +6     
===========================================
+ Hits           506      530      +24     
- Misses         262      272      +10     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This isn't used for anything??
@sb10 sb10 merged commit ea9186f into develop Jan 29, 2024
4 of 5 checks passed
@sb10 sb10 deleted the self-service-building branch January 29, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants