Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call project() before before enable_language() in CmakeLists.txt … #2125

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Quba1
Copy link

@Quba1 Quba1 commented Oct 30, 2024

This change fixes the warning appearing when calling configure_new with newer versions of Cmake.

TYPE: bug fix

KEYWORDS: cmake, configure

SOURCE: Jakub Lewandowski (University of Leeds)

DESCRIPTION OF CHANGES:
Problem:
When calling configure_new script with newer versions of Cmake (3.30.5 in my case) warning appears:

CMake Warning (dev) at CMakeLists.txt:5 (enable_language):
  project() should be called prior to this enable_language() call.
This warning is for project developers.  Use -Wno-dev to suppress it.

Solution:
This is easily fixable by calling project() before enable_language() as the warning suggests.

ISSUE: For use when this PR closes an issue.
n/a

LIST OF MODIFIED FILES: CmakeLists.txt

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

I tested the change on my machine and it solved the issue. As the change is very minor it should not cause issues for others.

RELEASE NOTE: Fixed CMake dev warning project() should be called prior to this enable_language() call appearing when using configure_new script with some newer versions of Cmake.

Copy link
Collaborator

@islas islas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants