-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Chem and Chem+KPP Build #2018
Open
islas
wants to merge
35
commits into
wrf-model:release-v4.6.1
Choose a base branch
from
islas:cmake-kpp
base: release-v4.6.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jenkins test results:
|
…applied globablly
… value This now mirrors the make build and allows the make build to supply the WRF_CHEM and WRF_KPP option via defines/command line similar to the make build. Likewise, while there are files that use or or any variation of this, these were never being used by the make build. This may be a bug, but the priority of the cmake build is to acheive parity with the make build in compile flags and overall effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: cmake, chem, kpp
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
Current CMake build does not build chem or chem+kpp configurations
Solution:
Build kpp and associated tools, and cmake commands to facilitate simplified logic of the
configure_wkc
andcompile_wkc
scripts. As with all CMake builds, all auto-generated source code is placed in the out-of-source build directory.Notable differences to make build :
-j N
parallel jobs to generate KPP sources up to a limitmodule_kpp_*
tuv_kpp
a directory to locate where include file is to be generated, and allow control of file IO mode*registry
uses-DWRF_CHEM
and-DWRF_KPP
defines passed at command line instead ofgetenv()
to match all other options**Affects make build in subtle ways but do not change user instructions
LIST OF MODIFIED FILES:
M CMakeLists.txt
M chem/CMakeLists.txt
A chem/KPP/CMakeLists.txt
M chem/KPP/compile_wkc
A chem/KPP/kpp/kpp-2.1/CMakeLists.txt
A chem/KPP/util/wkc/CMakeLists.txt
M chem/KPP/util/wkc/gen_kpp.c
M chem/KPP/util/wkc/protos_kpp.h
M chem/KPP/util/wkc/tuv_kpp.c
A chem/KPP/util/write_decomp/CMakeLists.txt
M chem/KPP/util/write_decomp/Makefile
M chem/KPP/util/write_decomp/integr_edit.c
M chem/chem_driver.F
M tools/CMakeLists.txt
M tools/data.h
M tools/registry.c
TESTS CONDUCTED:
RELEASE NOTE:
CMake Chem and Chem+KPP Build