-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiet compiler warnings for registry.exe #1858
base: develop
Are you sure you want to change the base?
Commits on Feb 8, 2024
-
STY: First pass at eliminating compiler warnings.
There might be more I wanted to add, but I don't remember. I'll have to add those the way I did the first time, compiling with -Werror until it works. This pass is almost exclusively focused on the registry. I'll have a few more for Fortran once I figure out how. Inspiration: registry was segfaulting, so I tried fixing the warnings in case it was one of those. It didn't work, but it's worth doing regardless.
Configuration menu - View commit details
-
Copy full SHA for 0ab3bb9 - Browse repository at this point
Copy the full SHA 0ab3bb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e252e5 - Browse repository at this point
Copy the full SHA 9e252e5View commit details -
BLD,BUG: Don't add warning flags to default compilation
Change compile flags back to what they were before.
Configuration menu - View commit details
-
Copy full SHA for 334a1a2 - Browse repository at this point
Copy the full SHA 334a1a2View commit details -
BUG: io.h only available on Windows/Cygwin
Guard io.h #include to avoid Linux compilation failures.
Configuration menu - View commit details
-
Copy full SHA for afd1c1a - Browse repository at this point
Copy the full SHA afd1c1aView commit details -
STY: Add sufficient space to more destination buffers.
Given how much space this provides at the moment, this had better not run over.
Configuration menu - View commit details
-
Copy full SHA for 173864f - Browse repository at this point
Copy the full SHA 173864fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba2eb1c - Browse repository at this point
Copy the full SHA ba2eb1cView commit details -
STY: Delete the partial posix_spawn calls.
Most likely the better solution is to look up functions to copy or delete files directly. I'm not sure where to look for those, but I'm pretty sure they're not in the C standard.
Configuration menu - View commit details
-
Copy full SHA for 22c4ba0 - Browse repository at this point
Copy the full SHA 22c4ba0View commit details -
STY: Remove the partial memory leak fix.
I pushed it to another branch, so a PR version can get some eyes on it.
Configuration menu - View commit details
-
Copy full SHA for 1208434 - Browse repository at this point
Copy the full SHA 1208434View commit details -
BUG: Declare gen_packs and gen_packs_halo return types as int
external/RSL_LITE implements these as int, so they need to be declared with int returns, not void.
Configuration menu - View commit details
-
Copy full SHA for 317d219 - Browse repository at this point
Copy the full SHA 317d219View commit details -
STY: Replace more integer literals with named constants.
Not quite all of them yet, but there's only one other, that one without an existing named constant. EDIT: There's about seventy left: I'll have to go through those again.
Configuration menu - View commit details
-
Copy full SHA for 8bdb29d - Browse repository at this point
Copy the full SHA 8bdb29dView commit details -
STY: Use TABLE_ENTRY for the max length of the KPP names
I think there's a way to pass this as a parameter to snprintf instead, but I don't remember what that is at the moment.
Configuration menu - View commit details
-
Copy full SHA for d51f4ca - Browse repository at this point
Copy the full SHA d51f4caView commit details -
STY: Pass number of characters in KPP name as printf argument
I looked up how to do this. Apparently you just stick a star for the width and put the variable with the width before the variable you want to have that width.
Configuration menu - View commit details
-
Copy full SHA for c116e16 - Browse repository at this point
Copy the full SHA c116e16View commit details -
STY: Two more file-path variables using NAMELEN.
grep -E -e '\[[[:digit:]]{2,}\]' *.[CcHhFf]*
Configuration menu - View commit details
-
Copy full SHA for 4ba1aab - Browse repository at this point
Copy the full SHA 4ba1aabView commit details -
STY: combine fprintf calls, replace sprintf with strcpy.
Lots of unused variables, but I should be able to leave those for a bit. Unused parameters would be a pain, so I'm leaving those.
Configuration menu - View commit details
-
Copy full SHA for 764c90d - Browse repository at this point
Copy the full SHA 764c90dView commit details
Commits on Feb 19, 2024
-
I wanted to make it a short to save space in the strings based on this, but given the push to optimize for clarity that's less relevant.
Configuration menu - View commit details
-
Copy full SHA for 894373e - Browse repository at this point
Copy the full SHA 894373eView commit details
Commits on Feb 29, 2024
-
Merge remote-tracking branch 'wrf-model/develop' into quiet-compiler-…
…warnings-registry Fix merge conflicts.
Configuration menu - View commit details
-
Copy full SHA for 75742b9 - Browse repository at this point
Copy the full SHA 75742b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77fbd16 - Browse repository at this point
Copy the full SHA 77fbd16View commit details -
STY: Revert narrowing of nChmOpts.
I made nChmOpts a short int to keep buffer size down. Given the change to named constants, this is likely irrelevant. On the other hand, it may currently max out at five.
Configuration menu - View commit details
-
Copy full SHA for 6dc8eb0 - Browse repository at this point
Copy the full SHA 6dc8eb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c12eee - Browse repository at this point
Copy the full SHA 6c12eeeView commit details