-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak: improves the templates number/date functions #660
Tweak: improves the templates number/date functions #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@alexmigf Do you have any idea how the customer could raise this error? Since it seems they didn't have the Pro extension. |
Not yet, it's still in discussion in the ticket. |
@MohamadNateqi it seems that the issue was caused by another plugin that creates a |
Totally agree. It's a good improvement. |
#659
This PR improves the templates display functions:
New functions:
Deprecated functions:
get_invoice_number
invoice_number
get_invoice_date
invoice_date
Changed functions:
get_number
: now includes$formatted
bool
argget_date
: now includes$formatted
bool
arg