Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bug on historical settings not being deleted when using most current settings #645

Conversation

alexmigf
Copy link
Member

@alexmigf alexmigf commented Nov 6, 2023

closes #643

Copy link
Contributor

@MohamadNateqi MohamadNateqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

includes/documents/abstract-wcpdf-order-document.php Outdated Show resolved Hide resolved
Copy link
Contributor

@Terminator-Barbapapa Terminator-Barbapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmigf alexmigf merged commit 3fbf568 into main Nov 7, 2023
5 checks passed
@alexmigf alexmigf deleted the 643-fix-bug-historical-settings-not-being-deleted-when-using-current branch November 7, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Historical settings not being deleted when using current settings
3 participants