Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests : backfill tests for Core Video Block #304

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Ta5r
Copy link
Contributor

@Ta5r Ta5r commented Sep 26, 2024

What:

This PR backfills tests for the Core Video block and its attributes.

Tested attributes :

  • align
  • anchor
  • autoplay
  • muted
  • caption
  • className
  • preload
  • src
  • style
  • playsInline
  • controls
  • loop
  • lock
  • poster
  • tracks
  • id

Untested fields:

  • CoreVideoAttribute.metadata - @todo

Exposed issues:

NA

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: d4d7374

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/wp-graphql-content-blocks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Ta5r
Copy link
Contributor Author

Ta5r commented Sep 26, 2024

c.c. @justlevine 🚀

@Ta5r Ta5r marked this pull request as ready for review September 26, 2024 06:48
@Ta5r Ta5r requested a review from a team as a code owner September 26, 2024 06:48
@justlevine
Copy link
Contributor

justlevine commented Sep 26, 2024

@Ta5r please add the parent branch dependency note to the PR description (as in rtCamp#29) since we can't change the base branch while still keeping it the PR accessible in this repo.

@jasonbahl jasonbahl merged commit 9a51bb0 into wpengine:main Oct 3, 2024
10 of 11 checks passed
@justlevine justlevine deleted the core-video-test branch October 18, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants