Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade wp-graphql-cs to 2.0.0-beta #163

Closed

Conversation

justlevine
Copy link
Contributor

This PR updates the plugin to use axepress/wp-graphql-cs:2.0.0-beta, which is based on WPCS 3.0+.

@justlevine justlevine requested a review from a team as a code owner November 27, 2023 17:46
Copy link

changeset-bot bot commented Nov 27, 2023

⚠️ No Changeset found

Latest commit: 2aedf54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@justlevine justlevine mentioned this pull request Nov 27, 2023
@theodesp
Copy link
Member

Thanks since its a branch of a branch lets review and merge the first branch and then review this branch ;P

@justlevine
Copy link
Contributor Author

justlevine commented Nov 28, 2023

Thanks since its a branch of a branch lets review and merge the first branch and then review this branch ;P

Your call. Did it this way instead of directly as suggestions on #162 because it was faster for me. Doesn't seem worthy of a separate changeset item, but your call if you prefer to wait until that's merged and then change the base branch here 🤷

@theodesp theodesp deleted the branch wpengine:chore/wp-graphql-cs November 29, 2023 10:17
@theodesp theodesp closed this Nov 29, 2023
@justlevine
Copy link
Contributor Author

@theodesp was this closed intentionally, or a side effect of deleting the target branch?

@theodesp
Copy link
Member

theodesp commented Nov 29, 2023

@justlevine probably a side-effect since this action happened automatically. Could you re-submit a new PR on the current main please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants