Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make delayjs exclusions collapsed by default #7211

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

wordpressfan
Copy link
Contributor

Description

Fixes #7210

This will simply make all categories of delayjs collapsed by default.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Before this PR, if u enabled delay JS feature, u will see the categories of exclusions like analytics, ads, ...etc. and by default the category of Analytics (the first one) was opened so here we need to close all of them.

Technical description

Documentation

We just removed the open class from analytics category.

New dependencies

No

Risks

No

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

It's a simple HTML change, didn't change anything in php code so it doesn't require tests.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@wordpressfan wordpressfan linked an issue Jan 2, 2025 that may be closed by this pull request
@wordpressfan wordpressfan marked this pull request as ready for review January 2, 2025 22:16
Copy link

codacy-production bot commented Jan 2, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fd1a88d) 38758 17139 44.22%
Head commit (fc8bf41) 38758 (+0) 17139 (+0) 44.22% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7211) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Jan 3, 2025

@wordpressfan Thanks for PR. List is closed now by default with fresh install, update and save (if with save is ok then we are good there https://wp-media.slack.com/archives/CUT7FLHF1/p1735886817148279?thread_ts=1735839635.615299&cid=CUT7FLHF1)
Screenshot from 2025-01-03 08-43-56
Screenshot from 2025-01-03 08-42-45

@MathieuLamiot MathieuLamiot requested a review from a team January 3, 2025 09:26
@jeawhanlee
Copy link
Contributor

Looks good to me, I have a question @wordpressfan, Why did we update the dynamic lists in this PR?

@wordpressfan
Copy link
Contributor Author

Looks good to me, I have a question @wordpressfan, Why did we update the dynamic lists in this PR?

Before updating the lists, the QA team needs to open tools and update the lists manually to get the data from v2 endpoint, but with updating them in json files, the manual update is not needed.
This was a leftover from the alpha release because we are releasing from 3.18 feature branch not develop.

@Mai-Saad Mai-Saad merged commit 7ce737a into feature/3.18 Jan 3, 2025
13 checks passed
@Mai-Saad Mai-Saad deleted the fix/7210-delayjs-exclusions-collapsed branch January 3, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.18 - One-Click exclusions UI update
3 participants