Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin family to fix rankmath custom download url #7207

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

wordpressfan
Copy link
Contributor

Description

Fixes #7201

Explain how this code impacts users.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Everything is mentioned in the issue and PR from plugin family, here is the mirror of changes only.

Technical description

Documentation

N/A

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

Everything is mentioned in the issue and PR from plugin family, here is the mirror of changes only.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@wordpressfan wordpressfan marked this pull request as ready for review December 30, 2024 08:19
Copy link

codacy-production bot commented Dec 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for f008e331 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f008e33) Report Missing Report Missing Report Missing
Head commit (65b652e) 38245 16727 43.74%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7207) 15 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jeawhanlee & @wordpressfan.
Tested and confirming that:

  • there is no regression (download+install+activate happens with one-click & user is kept on Our Plugins tab)

  • installation happens by slug:

Screenshot 2024-12-30 at 11 26 12
  • the download counter increments correctly after the button is clicked (confirmed with the RankMath team, on group.one slack #saas-eng-plugin-family, thread).

Note: An improbable use case that we're okay with, more details in thread.

@wordpressfan wordpressfan added this pull request to the merge queue Dec 30, 2024
Merged via the queue into develop with commit 432a68e Dec 30, 2024
11 of 12 checks passed
@wordpressfan wordpressfan deleted the fix/7201-update-plugin-family branch December 30, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install link of RankMath must change based on the plugin of origin (wp-rocket)
2 participants