Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #176: Backstop tests not working as expected for LLCSSBG & LRC tests when run generally #179

Conversation

jeawhanlee
Copy link
Contributor

Description

Creates backstop references for general test run.

Fixes #176
Fixes issue with backstop test not running as expected during general test run.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

  • Switch to develop and do a general test run (npm run test:e2e)

Technical description

Documentation

Added new step in feature files to create backstop references based on tags

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@jeawhanlee jeawhanlee requested a review from a team November 26, 2024 17:17
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Nov 27, 2024

We need to confirm:

  • running llcssbg only is green
  • Running LRC only is green
  • running all e2e => llcssbg is green , no regression compared to dev for other tests
  • no backstop reference is created if we only run smoke tests
  • backstop tabs at e2e have results (no 0 passed, 0 failed case)

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Nov 28, 2024

For llcssbg ✔️

  • tests are green
    Screenshot from 2024-11-28 13-04-52

  • we have 1 template failing to be investigated in separate GH
    Screenshot from 2024-11-28 13-03-44

  • backstop not having 0 passed/0failed ✔️

For lrc ✔️

@Mai-Saad Mai-Saad merged commit 2aeba3d into enhancement/167-failing-test-when-run-globally Nov 28, 2024
1 check passed
@Mai-Saad Mai-Saad deleted the fix/176-error-with-backstop-test-for-llcssbg-and-lrc branch November 28, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backstop tests not working as expected for LLCSSBG & LRC tests when run generally
3 participants