Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #173 Adds to clean-up the switch theme via WP CLI #178

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

hanna-meda
Copy link
Contributor

@hanna-meda hanna-meda commented Nov 25, 2024

Description

Updated clean-up method to include switch to 2020 theme via WP CLI
Removed step that did this in a specific scenario as it is no longer needed there now

Fixes #173
Explain how this code impacts users.

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Release

Detailed scenario

This can be checked on PR by:

  1. Running first this scenario & check theme in UI ===> active theme is Astra
  2. Run any other scenario & check theme in UI ===> theme is switched to 2020

Technical description

As per grooming

Documentation

As grooming

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@hanna-meda hanna-meda requested a review from a team November 25, 2024 20:54
@hanna-meda
Copy link
Contributor Author

hanna-meda commented Nov 27, 2024

Running test:e2e on PR with latest changes, with 3.17.3.zip as new release, only 1 failing test remains, related to "About Us" #170:
cucumber-report-178-e2e.html.zip
Screenshot 2024-11-27 at 14 12 00
Update: with 3.17.3.1.zip, results are different, 5 failing:
cucumber-report-178-3.17.3.1.html.zip
Screenshot 2024-11-27 at 15 56 47

@hanna-meda hanna-meda merged commit 22bc560 into develop Nov 27, 2024
2 checks passed
@hanna-meda hanna-meda deleted the fix-clean-up-to-include-switch-to-default-theme branch November 27, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up shall consider using 2020 whenever we change the theme while testing
3 participants