Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #149: Update scenario urls for delayjs #150

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jeawhanlee
Copy link
Contributor

@jeawhanlee jeawhanlee commented Sep 20, 2024

Description

Fixes #149
Explain how this code impacts users. This is a follow-up of this issue

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Running any of the following script below will trigger the references for delayjs to be created

"test:delayjs:genesis": "THEME=genesis-sample-develop $npm_package_config_testCommand --tags @delayjs",
"test:delayjs:flatsome": "THEME=flatsome $npm_package_config_testCommand --tags @delayjs",
"test:delayjs:divi": "THEME=Divi $npm_package_config_testCommand --tags @delayjs",
"test:delayjs:astra": "THEME=astra $npm_package_config_testCommand --tags @delayjs",

Technical description

Documentation

Adds delayjs urls for backstop to create reference anytime any delayjs related test is run.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I did not introduce unnecessary complexity.

@jeawhanlee jeawhanlee added bug Something isn't working enhancement New feature or request labels Sep 20, 2024
@jeawhanlee jeawhanlee self-assigned this Sep 20, 2024
@jeawhanlee jeawhanlee requested a review from a team September 20, 2024 13:15
@Mai-Saad
Copy link
Contributor

Tests are green here except for genesis mobile due to missing exclusion at BE https://wp-media.slack.com/archives/C05NH7JU4S2/p1727075603920419?thread_ts=1726838165.260239&cid=C05NH7JU4S2

@jeawhanlee
Copy link
Contributor Author

There is a follow-up here: #151. We have more context on this thread but for now I think we are good here.

@jeawhanlee jeawhanlee merged commit c25ac8a into develop Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update scenario urls for delayjs
3 participants