Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override table heading attrs #265

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Conversation

dsrees
Copy link
Contributor

@dsrees dsrees commented Sep 16, 2023

Description

Issue #263 - Overriding attrs for table heading

  • Renamed table.col.attrs to table.col.td_attrs
  • Added table.col.th_attrs to override table.thead_th_attrs
  • Added table.col.th_wrapper_attrs to override table.th_wrapper_attrs

Checklist

  • I added tests that cover my proposed changes.
  • I updated the documentation related to my changes (if applicable).

resolves #263

@coveralls
Copy link

coveralls commented Sep 26, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 7a17a18 on dsrees:override-table-heading-attrs into df23478 on woylie:main.

@woylie
Copy link
Owner

woylie commented Sep 26, 2023

Thanks, looks good, but the formatter and credo are complaining.

@woylie woylie merged commit bef307e into woylie:main Sep 26, 2023
14 checks passed
@dsrees dsrees deleted the override-table-heading-attrs branch September 26, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overriding attrs for table heading
3 participants