evm: Add support for adapter instructions #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
evm_adapter_instructions
branch
from
8fd6445 to
f442f4f
Compare
bruce-riley
force-pushed
the
evm_adapter_instructions
branch
2 times, most recently
from
51b59d0 to
eefdf75
Compare
bruce-riley
force-pushed
the
evm_adapter_instructions
branch
from
eefdf75 to
82533d5
Compare
bruce-riley
force-pushed
the
evm_adapter_instructions
branch
from
45b047e to
8f9b270
Compare
bruce-riley
changed the title
panoel
reviewed
Dec 11, 2024
panoel
reviewed
Dec 11, 2024
panoel
reviewed
Dec 11, 2024
panoel
previously approved these changes
Dec 11, 2024
|
Created issue #48 to investigate whether we should pass the instructions in as an array rather than as encoded bytes. For now, will stick with encoded bytes because that is what NTT is doing. |
panoel
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
sendMessageandquoteDeliveryPriceto take encoded adapter instructions. It parses them into the per-adapter instructions and passes them into the adapter functions.To do this, it adds a new
AdapterInstructionslibrary along with tests for it.