Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate encoding of adapter instructions #48

Open
bruce-riley opened this issue Dec 11, 2024 · 0 comments
Open

Investigate encoding of adapter instructions #48

bruce-riley opened this issue Dec 11, 2024 · 0 comments

Comments

@bruce-riley
Copy link
Collaborator

Currently, the adapter instructions passed into sendMessage and quoteDeliveryPrice are encoded into bytes, which requires decoding back into an array. This follows the model used in NTT. It's possible that it would be more efficient to just pass in an array. Should do some testing to see if that is the case.

Forge testing indicates that for two or less adapters, passing in the array is faster, but for three or more, the encoded bytes is faster. It is possible that passing in the array from the front end may require transferring considerably more data, which may be more expensive.

A more detailed analysis is required, probably with anvil testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant