Skip to content

Commit

Permalink
Revert back to 0.8.4 + PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
djb15 committed Jul 10, 2024
1 parent 50289c0 commit 0c82894
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 12 deletions.
2 changes: 1 addition & 1 deletion ethereum/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ lib/openzeppelin-contracts:
forge install openzeppelin/openzeppelin-contracts@0457042d93d9dfd760dbaa06a4d2f1216fdbe297 --no-git --no-commit

lib/wormhole-solidity-sdk:
forge install wormhole-foundation/wormhole-solidity-sdk@b9e129e65d34827d92fceeed8c87d3ecdfc801d0 --no-git --no-commit
forge install djb15/wormhole-solidity-sdk@78f4b5e1d1ce4c36e43522c9205eb1e92fde7106 --no-git --no-commit

dependencies: node_modules forge_dependencies

Expand Down
12 changes: 2 additions & 10 deletions ethereum/contracts/Messages.sol
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,10 @@ pragma experimental ABIEncoderV2;

import "./Getters.sol";
import "./Structs.sol";
import "./libraries/external/BytesLib.sol";
import "wormhole-solidity-sdk/libraries/BytesParsing.sol";
import "wormhole-sdk/libraries/BytesParsing.sol";


contract Messages is Getters {
using BytesLib for bytes;
using BytesParsing for bytes;

uint8 private constant ADDRESS_SIZE = 20; // in bytes
Expand Down Expand Up @@ -219,13 +217,7 @@ contract Messages is Getters {
}

/// @dev Verify the proposed vm.signatures against the guardianSet
(bool signaturesValid, string memory invalidReason) = verifySignatures(hash, signatures, guardianSet);
if(!signaturesValid){
return (false, invalidReason);
}

/// If we are here, we've validated the VM is a valid multi-sig that matches the current guardianSet.
return (true, "");
return verifySignatures(hash, signatures, guardianSet);
}

/**
Expand Down
3 changes: 2 additions & 1 deletion ethereum/foundry.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[profile.default]
solc_version = "0.8.13"
solc_version = "0.8.4"
optimizer = true
optimizer_runs = 200
via_ir = false
Expand All @@ -17,6 +17,7 @@ remappings = [
'ds-test/=lib/forge-std/lib/ds-test/src/',
'forge-std/=lib/forge-std/src/',
'truffle/=node_modules/truffle/',
'wormhole-sdk/=lib/wormhole-solidity-sdk/src/'
]

[fmt]
Expand Down

0 comments on commit 0c82894

Please sign in to comment.