Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix my sloppy oversight of asUint8 missing unchecked suffix in asBool… #25

Merged
merged 3 commits into from
Jan 16, 2024
Merged

fix my sloppy oversight of asUint8 missing unchecked suffix in asBool… #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30fb63e
fix my sloppy oversight of asUint8 missing unchecked suffix in asBool…
nonergodic Jan 11, 2024
2285c27
fix remove assembly which fails to account for dirty upper 31 bytes
nonergodic Jan 11, 2024
ff5947d
hopefully more efficient impl
nonergodic Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/libraries/BytesParsing.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,15 @@ library BytesParsing {
bytes memory encoded,
uint offset
) internal pure returns (bool, uint) {
(uint8 val, uint nextOffset) = asUint8(encoded, offset);
(uint8 val, uint nextOffset) = asUint8Unchecked(encoded, offset);
if (val & 0xfe != 0)
revert InvalidBoolVal(val);

uint cleanedVal = uint(val);
bool ret;
//skip 2x iszero opcode
assembly ("memory-safe") {
ret := val
ret := cleanedVal
}
return (ret, nextOffset);
}
Expand Down