bugfix: prevent proxy upgrade to addresses with no code

wormhole-foundation · Dec 19, 2024 · fa686b5 · fa686b5
1 parent a126d90
commit fa686b5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/proxy/ProxyBase.sol b/src/proxy/ProxyBase.sol
@@ -8,6 +8,7 @@ error InvalidSender();
 error IdempotentUpgrade();
 error InvalidMsgValue();
 error InvalidData();
+error InvalidImplementation();
 error UpgradeFailed(bytes revertData);
 
 event Upgraded(address indexed implementation);
@@ -40,6 +41,9 @@ abstract contract ProxyBase {
     if (newImplementation == implementationState().implementation)
       revert IdempotentUpgrade();
 
+    if (newImplementation.code.length == 0)
+      revert InvalidImplementation();
+
     implementationState().implementation = newImplementation;
 
     (bool success, bytes memory revertData) =

diff --git a/test/Proxy.t.sol b/test/Proxy.t.sol
@@ -5,7 +5,12 @@ pragma solidity ^0.8.24;
 import "forge-std/Test.sol";
 
 import { adminState } from "wormhole-sdk/proxy/Eip1967Admin.sol";
-import { ProxyBase, UpgradeFailed, InvalidData } from "wormhole-sdk/proxy/ProxyBase.sol";
+import {
+  ProxyBase,
+  UpgradeFailed,
+  InvalidData,
+  InvalidImplementation
+} from "wormhole-sdk/proxy/ProxyBase.sol";
 import { Proxy, ProxyConstructionFailed } from "wormhole-sdk/proxy/Proxy.sol";
 
 error NotAuthorized();
@@ -104,4 +109,12 @@ contract TestProxy is Test {
     assertEq(contrct.immutableNum(), 1);
     assertEq(contrct.message(), "v2");
   }
-}
+
+  function testProxyInvalidUpgradeFails() public {
+    address logic1 = address(new LogicContractV1(1));
+    LogicContractV1 contrct = LogicContractV1(address(new Proxy(logic1, abi.encode("v1"))));
+
+    vm.expectRevert(InvalidImplementation.selector);
+    contrct.customUpgradeFun(makeAddr("wrongAddress"), abi.encode("oops"));
+  }
+}