Cascading Merkle Tree #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dzejkop
reviewed
Apr 4, 2024
Dzejkop
reviewed
Apr 4, 2024
Dzejkop
reviewed
Apr 4, 2024
Dzejkop
reviewed
Apr 4, 2024
Dzejkop
reviewed
Apr 4, 2024
0xForerunner
force-pushed
the
ewoolsey/dynamic-tree
branch
from
015732a
to
dcc5af1
Compare
Dzejkop
reviewed
Apr 5, 2024
| depth: usize, | ||
| root: H::Hash, | ||
| empty_value: H::Hash, | ||
| sparse_column: Vec<H::Hash>, |
There was a problem hiding this comment.
Could we add a little comment here explaining what this field is? As I understand these are the values of empty subtrees by depth
Dzejkop
approved these changes
Apr 5, 2024
Dzejkop
approved these changes
Apr 12, 2024
no need to specify initial capacity in the `create` methods as `.resize(new_capacity)` can be called afterwards for the same effect
Dzejkop
force-pushed
the
ewoolsey/dynamic-tree
branch
from
aad8156
to
f20b9f8
Compare
0xKitsune
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this up as a draft! I think this is pretty close to where I would like it to be. Please let me know if you guys have any suggestions here!