mcu-util: serial can only be obtained if orb-ui not running #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fouge
force-pushed
the
fouge/mcu-util-blocking-call
branch
from
b4c2eb2
to
fc65538
Compare
fouge
force-pushed
the
fouge/mcu-util-serial-opt
branch
from
81d8356
to
7d2a561
Compare
make it optional still unused anyway
fouge
force-pushed
the
fouge/mcu-util-serial-opt
branch
from
7d2a561
to
0539573
Compare
TheButlah
approved these changes
May 4, 2024
TheButlah
added a commit
that referenced
this pull request
May 7, 2024
* mcu-util: refactor blocking call to can-rs in async and some tiny refacto * mcu-util: serial can only be obtained if orb-ui not running (#86) make it optional still unused anyway * mcu-util: better errors and printing (#87) * mcu-util: serial can only be obtained if orb-ui not running make it optional still unused anyway * mcu-util: better errors (and printing) unwrap all errors * No need to annotate, the type is already clear. Co-authored-by: Ryan Butler <[email protected]> * mcu-util: correctly form can-fd frame * mcu-util: create and check ack number from functions * mcu-util: better logs (#91) * mcu-util: better logs use color-eyre use RUST_LOG env variable when given fallback on INFO log level * mcu-util: remove some allow(dead_code) * mcu-util: remove useless Arc give ownership to blocking thread --------- Co-authored-by: Ryan Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it optional
still unused anyway