Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orb-ui: Dynamically change language #75

Merged
merged 2 commits into from
Apr 16, 2024
Merged

orb-ui: Dynamically change language #75

merged 2 commits into from
Apr 16, 2024

Conversation

fouge
Copy link
Collaborator

@fouge fouge commented Apr 16, 2024 •
edited
Loading

tested with UI events below, to be used with the ui-replay binary.

Apr 16 15:39:31 localhost worldcoin-ui[17338]: 2024-04-16T15:39:31.442272Z  INFO orb_ui::engine::pearl: UI event: {"SoundVolume":{"level":40}}
Apr 16 15:39:31 localhost worldcoin-ui[17338]: 2024-04-16T15:39:31.443722Z  INFO orb_ui::engine::pearl: UI event: {"SoundLanguage":{"lang":"en-US"}}
Apr 16 15:39:31 localhost worldcoin-ui[17338]: 2024-04-16T15:39:31.706397Z  INFO orb_ui::engine::pearl: UI event: {"QrScanTimeout":{"schema": "Operator"}}
Apr 16 15:39:31 localhost worldcoin-ui[17338]: 2024-04-16T15:39:31.813578Z  INFO orb_ui::engine::pearl: UI event: {"SoundVolume":{"level":40}}
Apr 16 15:39:31 localhost worldcoin-ui[17338]: 2024-04-16T15:39:31.814760Z  INFO orb_ui::engine::pearl: UI event: {"SoundLanguage":{"lang":"es-ES"}}
Apr 16 15:39:31 localhost worldcoin-ui[17338]: 2024-04-16T15:39:31.996397Z  INFO orb_ui::engine::pearl: UI event: {"QrScanTimeout":{"schema": "Operator"}}

fixes O-2610

@fouge fouge requested a review from TheButlah April 16, 2024 15:54
@fouge fouge force-pushed the fouge/orb-ui-language branch 2 times, most recently from 8d1128e to 518c45f Compare April 16, 2024 16:28
@karelispanagiotis karelispanagiotis changed the title orb-ui: dynamically change language orb-ui: Dynamically change language Apr 16, 2024
karelispanagiotis
karelispanagiotis approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@karelispanagiotis karelispanagiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also tested with https://github.com/worldcoin/priv-orb-core/pull/1160 and I confirm it works!

@karelispanagiotis karelispanagiotis merged commit 7ed194c into main Apr 16, 2024
9 checks passed
@karelispanagiotis karelispanagiotis deleted the fouge/orb-ui-language branch April 16, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelispanagiotis karelispanagiotis karelispanagiotis approved these changes

@TheButlah TheButlah Awaiting requested review from TheButlah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fouge @karelispanagiotis