scripts: nit support 'short' certificate uploading #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
force-pushed
the
sfikas/upload-short-provisioning
branch
from
348ca9e
to
ea3cba7
Compare
|
We can create other script for that but feedback from batch fixing orbs is that copy and upload should not be 2 different scripts. It's handy to just write one. Or (ideally) all of them 3 should be placed later in one script |
sfikastheo
force-pushed
the
sfikas/upload-short-provisioning
branch
from
ea3cba7
to
f3ca521
Compare
|
@AlexKaravaev my idea is to have these as separate, and have one script that can perform the whole process |
AlexKaravaev
approved these changes
Nov 19, 2024
| -X POST "https://${domain}/api/v1/certificate" \ | ||
| -d '{ "orbId": "'"${orb_id}"'", "certificate": "'"${certificate}"'" }' | ||
| # Post attestation certificate | ||
| if [[ ! "${short}" ]]; then |
There was a problem hiding this comment.
Another usage feedback that I had is that a lot of times dir name is the orb-id, so we don't need to provide that explicitely. We can use that in next script that combines both copy/upload.
AlexKaravaev
force-pushed
the
sfikas/upload-short-provisioning
branch
from
f3ca521
to
328d818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.