test(sound): check sound files in rust tests #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fouge
force-pushed
the
fouge/sound-files
branch
4 times, most recently
from
0e96adf
to
c742f22
Compare
fouge
commented
Oct 28, 2024
.github/workflows/rust-ci.yaml
Outdated
| @@ -148,8 +149,8 @@ jobs: | |||
| cat ${GITHUB_ENV} | |||
| - name: Cargo Test | |||
| run: | | |||
| nix develop -c \ | |||
| cargo test --all --all-features --all-targets $EXCLUDES | |||
| SOUNDS_DIR=$(pwd)/ui/sound/assets nix develop -c \ | |||
There was a problem hiding this comment.
i don't like setting this variable here but i didn't find a better approach :/
There was a problem hiding this comment.
lets use a config struct rather than this global env var
TheButlah
requested changes
Nov 13, 2024
.github/workflows/rust-ci.yaml
Outdated
| @@ -148,8 +149,8 @@ jobs: | |||
| cat ${GITHUB_ENV} | |||
| - name: Cargo Test | |||
| run: | | |||
| nix develop -c \ | |||
| cargo test --all --all-features --all-targets $EXCLUDES | |||
| SOUNDS_DIR=$(pwd)/ui/sound/assets nix develop -c \ | |||
There was a problem hiding this comment.
lets use a config struct rather than this global env var
fouge
force-pushed
the
fouge/sound-files
branch
3 times, most recently
from
4efdcd4
to
ae17f2c
Compare
TheButlah
approved these changes
Nov 14, 2024
| use std::time::Duration; | ||
|
|
||
| struct MockJetson { | ||
| sound_files: Arc<DashMap<Type, SoundFile>>, |
There was a problem hiding this comment.
Why do we need a DashMap when we aren't mutating this variable?
instead of invoking soxi check that all files are present in the assets check bits per sample (16 bits) sounds directory based on cargo manifest path for tests. tests are run with all other rust tests
fouge
force-pushed
the
fouge/sound-files
branch
from
ae17f2c
to
7666a97
Compare
TheButlah
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of invoking soxi
check that all files are present in the assets
check bits per sample (16 bits)
SOUNDS_DIR can be overwritten at runtime with an env variable tests are run with all other rust tests