Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hil): Add button control cmd and timeout for cmd #281

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(hil): Add button control cmd and timeout for cmd #281

wants to merge 2 commits into from

Conversation

AlexKaravaev
Copy link
Contributor

No description provided.

fouge
fouge reviewed Nov 6, 2024
View reviewed changes
hil/src/utils.rs Outdated Show resolved Hide resolved
fouge
fouge approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@fouge fouge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from delegating the parsing of the timeout, the rest looks good to me :)
(i didn't test)

@TheButlah TheButlah added the blocked:author PR is waiting for author label Nov 14, 2024
@AlexKaravaev AlexKaravaev removed the blocked:author PR is waiting for author label Nov 20, 2024
@AlexKaravaev
Copy link
Contributor Author

@TheButlah what do we do about security complaining? zeta12ti/parse_duration#21 this is not relevant at all for cli command use-case probably

@AlexKaravaev
Copy link
Contributor Author

nvm, will switch to https://docs.rs/humantime/latest/humantime/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fouge fouge fouge approved these changes

@TheButlah TheButlah Awaiting requested review from TheButlah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKaravaev @fouge @TheButlah