Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: generation of new orb-ids && registration support #231

Merged
merged 3 commits into from
Nov 12, 2024
Merged

utils: generation of new orb-ids && registration support #231

merged 3 commits into from
Nov 12, 2024

Conversation

sfikastheo
Copy link
Contributor

  • Rewrite of orb-generation scripts and automatic registration

@sfikastheo sfikastheo marked this pull request as draft September 23, 2024 12:02
@sfikastheo sfikastheo marked this pull request as ready for review September 24, 2024 18:00
oldgalileo
oldgalileo previously requested changes Sep 24, 2024
View reviewed changes
scripts/generate-new-orb-id/gen-orb-id.sh Outdated Show resolved Hide resolved
scripts/generate-new-orb-id/gen-orb-id.sh Outdated Show resolved Hide resolved
scripts/generate-new-orb-id/gen-orb-id.sh Outdated Show resolved Hide resolved
scripts/generate-new-orb-id/gen-orb-id.sh Outdated Show resolved Hide resolved
scripts/generate-new-orb-id/gen-orb-id.sh Outdated Show resolved Hide resolved
scripts/generate-new-orb-id/gen-orb-id.sh Outdated Show resolved Hide resolved
scripts/generate-new-orb-id/gen-orb-id.sh Outdated Show resolved Hide resolved
@oldgalileo
Copy link
Contributor

Most of that review is small nits (logical ordering, writing to stderr). The only thing that must be fixed is the release_type handling.

@TheButlah TheButlah added the blocked:author PR is waiting for author label Oct 1, 2024
@TheButlah TheButlah added blocked:reviewer PR is waiting for the reviewer and removed blocked:author PR is waiting for author labels Oct 1, 2024
@TheButlah
Copy link
Collaborator

@sfikastheo @oldgalileo this PR is stale. @sfikastheo is it functional? If so, I will merge it.

@TheButlah
Copy link
Collaborator

Approving, we should merge because this is getting stale. @sfikastheo can you rebase?

@sfikastheo sfikastheo enabled auto-merge (squash) October 28, 2024 20:43
@TheButlah TheButlah removed the request for review from oldgalileo November 12, 2024 19:56
@TheButlah TheButlah merged commit 0a7922a into main Nov 12, 2024
9 of 10 checks passed
@TheButlah TheButlah deleted the sfikas/utils-generate-orb branch November 12, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheButlah TheButlah TheButlah approved these changes

@oldgalileo oldgalileo oldgalileo left review comments

Assignees
No one assigned
Labels
blocked:reviewer PR is waiting for the reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfikastheo @oldgalileo @TheButlah