orb-const-concat: initial commit #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
force-pushed
the
thebutlah/const_concat
branch
from
823c62e
to
de52f79
Compare
TheButlah
changed the title
TheButlah
force-pushed
the
thebutlah/const_concat
branch
2 times, most recently
from
6c68633
to
53968e2
Compare
TheButlah
force-pushed
the
thebutlah/const_concat
branch
from
53968e2
to
5885dd3
Compare
TheButlah
changed the title
TheButlah
changed the title
fouge
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't like that the const_format crate is so incredibly complex. There is a lot of unsafe and also a lot of cursed code in it.
I would much rather use a solution that covers the 80% use case of concatenating strings with 0 unsafe, minimal LOC, and less SBOM risk.