orb-slot-ctrl: Prettify handling of arguments from user #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
requested changes
Jun 6, 2024
TheButlah
requested changes
Jun 6, 2024
AlexKaravaev
commented
Jun 18, 2024
AlexKaravaev
commented
Jun 18, 2024
I've also added clap parsing for Slot |
AlexKaravaev
force-pushed
the
alex/prettify-slot-ctrl-args
branch
from
8ab2572
to
17eee28
Compare
AlexKaravaev
force-pushed
the
alex/prettify-slot-ctrl-args
branch
from
17eee28
to
923cd59
Compare
|
@AlexKaravaev can you close or bring up to date? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that parsing of status command is a bit clunky, so improved it a bit. I wanted to also add tests for this in this module, but writing tests for cli will require some more refactoring for this file, so I didn't bothered