orb-mcu-util: don't fail on build #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fouge
force-pushed
the
fouge/mcu-util-dont-fail
branch
from
51b5b73
to
6762d86
Compare
when fetching data, don't fail but prefer unfilled struct
fouge
force-pushed
the
fouge/mcu-util-dont-fail
branch
from
6762d86
to
a114f8f
Compare
TheButlah
requested changes
Jun 6, 2024
on error, it means board info is incomplete
TheButlah
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when fetching data, don't fail
but prefer unfilled struct
@TheButlah i'd like your thought on this kind of construct. I think it's fine not to fail when fetching the data so that we can at least print the pieces of info that were fetched.