mcu-util: pull out messaging module into a crate #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
force-pushed
the
thebutlah/pull-out-can
branch
from
d5437f0
to
f37f26b
Compare
TheButlah
force-pushed
the
thebutlah/pull-out-can
branch
from
f37f26b
to
85d27bb
Compare
TheButlah
force-pushed
the
thebutlah/pull-out-can
branch
from
a35d3ec
to
40cf32d
Compare
fouge
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #116
We currently duplicate this code in orb-mcu-util and orb-mcu-telemetry, pulling it into its own crate will let the telemetry tool use it.
We also need to access can messages in orb-supervisor, so bringing this into a crate will help with that.