ci: autodetect cargo deb crates #101
Conversation
TheButlah
force-pushed
the
thebutlah/autodetect-deb-crates
branch
from
0d6628e
to
1ed5756
Compare
TheButlah
force-pushed
the
thebutlah/autodetect-deb-crates
branch
from
1ed5756
to
728c8a5
Compare
|
|
||
| targets = ["aarch64", "x86_64"] | ||
| def find_cargo_deb_crates(): | ||
| jq_query = ( |
There was a problem hiding this comment.
The alternative in Python would be (something along these lines):
metadata = json.loads(cmd_output)
workspace_members = set(metadata['workspace_members'])
crates = [
package['name']
for package in metadata['packages']
if package['id'] in workspace_members and 'deb' in package.get('metadata', {})
]
I personally find it more understandable. But I'll leave this to you.
Is jq always available btw? Because with pure python implementation you have the advantage of "peace of mind".
There was a problem hiding this comment.
we ensure that jq is always available via the nix flake. But yes, I think I prefer the python approach more. Also, I know python more than I know jq. I'll open a new PR to port it.
| ) | ||
|
|
||
|
|
||
| def main(): | ||
| parser = argparse.ArgumentParser(description="Builds rust artifacts for CI") |
There was a problem hiding this comment.
very nit for whenever (if) you have time: It would be amazing to have a description that our artifacts are actually debian packages, and also have the description declaring what are the assumptions under which we can build a debian.
Lets us stop having to manually write out the list of binaries. Also will allow us to reuse this workflow in orb-internal, since it is no longer specific to this repo.
Also seeking opinions: Would it be better for me to keep the json parsing in jq, or do you want me to port it to native python?