Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terraform and workflow to deploy Reporting V2 #1223

Merged

Conversation

tristanvuong2021
Copy link
Contributor

@tristanvuong2021 tristanvuong2021 commented Sep 13, 2023

There will be one cluster for Reporting V1 and one cluster for Reporting V2.

@wfa-reviewable
Copy link

This change is Reviewable

@tristanvuong2021 tristanvuong2021 changed the title Update workflow to deploy Reporting V2 instead of Reporting V1. Update workflow to deploy Reporting V2 Sep 21, 2023
@tristanvuong2021 tristanvuong2021 force-pushed the tristanvuong-configure-reporting-workflow-to-deploy-v2 branch from 64b44de to 92aa7f8 Compare September 21, 2023 16:37
Copy link
Contributor

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

@tristanvuong2021 tristanvuong2021 force-pushed the tristanvuong-configure-reporting-workflow-to-deploy-v2 branch from 48cfa61 to ca20947 Compare January 25, 2024 18:05
@tristanvuong2021 tristanvuong2021 marked this pull request as ready for review January 25, 2024 18:49
@tristanvuong2021 tristanvuong2021 changed the title Update workflow to deploy Reporting V2 Update terraform and workflow to deploy Reporting V2 Jan 25, 2024
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 6 of 6 files at r3, 2 of 2 files at r4.
Reviewable status: 8 of 9 files reviewed, 3 unresolved discussions (waiting on @tristanvuong2021)


.github/workflows/configure-reporting-v2.yml line 89 at r4 (raw file):

      run: >
        bazelisk build 
        "//src/main/k8s/dev:reporting_v2.tar"

nit: why is this in quotes?


.github/workflows/terraform-cmms.yml line 99 at r4 (raw file):

      working-directory: ${{ env.GCLOUD_MODULE_PATH }}
      run: terraform apply -input=false tfplan

Why was this all removed? This is needed for the worker2 Duchy which runs in AWS.


src/main/terraform/gcloud/cmms/reporting_v2.tf line 15 at r4 (raw file):

# limitations under the License.

module "reporting_cluster" {

These names all need to be changed I think. Terraform basically just concats all the .tf files together.

Code quote:

"reporting_cluster"

Copy link
Contributor Author

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 10 files reviewed, 3 unresolved discussions (waiting on @Marco-Premier and @SanjayVas)


.github/workflows/configure-reporting-v2.yml line 89 at r4 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

nit: why is this in quotes?

I copied it from the other file. I removed quotes from both


.github/workflows/terraform-cmms.yml line 99 at r4 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Why was this all removed? This is needed for the worker2 Duchy which runs in AWS.

I removed it to try to make the testing run faster.


src/main/terraform/gcloud/cmms/reporting_v2.tf line 15 at r4 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

These names all need to be changed I think. Terraform basically just concats all the .tf files together.

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r6, all commit messages.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)


.github/workflows/terraform-cmms.yml line 99 at r4 (raw file):

Previously, tristanvuong2021 (Tristan Vuong) wrote…

I removed it to try to make the testing run faster.

Leave it commented out with a DO_NOT_SUBMIT comment then so it's clear that you intend to put it back before submitting.

Copy link
Contributor Author

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 16 files reviewed, 1 unresolved discussion (waiting on @Marco-Premier and @SanjayVas)


.github/workflows/terraform-cmms.yml line 99 at r4 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Leave it commented out with a DO_NOT_SUBMIT comment then so it's clear that you intend to put it back before submitting.

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 11 files at r7, 4 of 4 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)


src/main/k8s/reporting_v2.cue line 21 at r8 (raw file):

	_verboseGrpcClientLogging: bool | *false

	_reportSchedulingCronSchedule: "30 6 * * *" // Daily at 6:30 AM

Shouldn't this be overridable?

Suggestion:

_reportSchedulingCronSchedule: string | *"30 6 * * *" // Daily at 6:30 AM

Copy link
Contributor Author

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/k8s/reporting_v2.cue line 21 at r8 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Shouldn't this be overridable?

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 6 files at r3, 2 of 5 files at r6, 7 of 11 files at r7, 4 of 4 files at r8, 1 of 1 files at r9.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

@tristanvuong2021 tristanvuong2021 merged commit fc6df03 into main Jan 29, 2024
5 checks passed
@tristanvuong2021 tristanvuong2021 deleted the tristanvuong-configure-reporting-workflow-to-deploy-v2 branch January 29, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants