Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use runtime extensions for language dependencies, don't copy em #602

Closed
wants to merge 1 commit into from

Conversation

orowith2os
Copy link

Makes it easier to get things like bugfixes for Rust faster.

Needs lots of testing, and I'm not sure this'll even work. But it's an attempt.

Makes it easier to get things like bugfixes for Rust faster.

Signed-off-by: Dallas Strouse <[email protected]>
@UrtsiSantsi
Copy link
Contributor

Copying them after compile really slows the development workflow, using runtime extensions will be wonderful.

@orowith2os
Copy link
Author

The main issue is, does this even work? Because using a generated bundle, it looks like it doesn't. The Vala extension isn't pulled in when installing it if I omit it from sdk-extensions. It should be, but isn't.

@UrtsiSantsi
Copy link
Contributor

UrtsiSantsi commented Sep 18, 2023

Not sure, I was getting some build errors myself with my branch last week and now I see #604.
I'll try your changes once 45 is out.

Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between sdk-extensions and add-extensions ?

Do we need add-extensions if we use org.gnome.Sdk as runtime ?

@orowith2os
Copy link
Author

add-extensions is for runtime extensions; sdk-extensions is for build-time extensions, at least afaik.

@sonnyp
Copy link
Contributor

sonnyp commented Sep 22, 2023

yes but if we use Sdk as runtime I guess it endsup not making a difference?

Anyway, I have created a ticket about Workbench size #621

@orowith2os
Copy link
Author

orowith2os commented Sep 22, 2023 via email

@sonnyp
Copy link
Contributor

sonnyp commented Sep 22, 2023

I'm aware :)

@sonnyp
Copy link
Contributor

sonnyp commented Sep 22, 2023

I created a ticket about reducing Workbench size #621

I think we an close this if you want.

@orowith2os
Copy link
Author

I'd rather do this, but whatever works.

@sonnyp
Copy link
Contributor

sonnyp commented Sep 24, 2023

This doesn't work unfortunately.
But even if it did, I'd prefer the extensions to be optional as we want to optimize for initial download size.

@sonnyp sonnyp closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants