Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library: Ported View switcher to rust #594

Merged
merged 11 commits into from
Sep 17, 2023
Merged

library: Ported View switcher to rust #594

merged 11 commits into from
Sep 17, 2023

Conversation

saadulkh
Copy link
Contributor

Check button is not working right now. @Hofer-Julian Plz have a look.

Hofer-Julian
Hofer-Julian reviewed Sep 15, 2023
View reviewed changes
src/Library/demos/View Switcher/code.rs Outdated Show resolved Hide resolved
src/Library/demos/View Switcher/code.rs Outdated Show resolved Hide resolved
src/Library/demos/View Switcher/code.rs Outdated Show resolved Hide resolved
@saadulkh
Copy link
Contributor Author

saadulkh commented Sep 15, 2023 •
edited
Loading

Should I synchronize the JavaScript version too?
@sonnyp
Tho it seems that it can work the JavaScript way.

@sonnyp
Copy link
Contributor

sonnyp commented Sep 16, 2023

@saadulkh yes, we should keep ports in sync with each others. Thanks!

@Hofer-Julian
Copy link
Contributor

Thanks, @saadulkh.
Do you think you could update the Vala example as well?

@saadulkh
Copy link
Contributor Author

saadulkh commented Sep 17, 2023 •
edited
Loading

Thanks, @saadulkh. Do you think you could update the Vala example as well?

Lemme give it a try.

Edit: Done

@saadulkh saadulkh requested a review from lw64 as a code owner September 17, 2023 16:44
@Hofer-Julian
Copy link
Contributor

One small warning from the Javascript linter in the CI, then we are ready to go :)

@saadulkh
Copy link
Contributor Author

saadulkh commented Sep 17, 2023 •
edited
Loading

Some problem with the CI now?

It is not happy with change in indentation ig.

Hofer-Julian
Hofer-Julian approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks a lot! 😁

@Hofer-Julian Hofer-Julian merged commit 3b0f109 into workbenchdev:main Sep 17, 2023
1 check passed
@saadulkh saadulkh deleted the view-switcher branch September 17, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

@sonnyp sonnyp Awaiting requested review from sonnyp sonnyp is a code owner

@lw64 lw64 Awaiting requested review from lw64 lw64 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saadulkh @sonnyp @Hofer-Julian