Test alternative Gutenberg + XCFramework + Hermes setup #21128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21128-5a110c3 | |
| Version | 22.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 5a110c3 | |
| App Center Build | WPiOS - One-Offs #6405 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21128-5a110c3 | |
| Version | 22.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 5a110c3 | |
| App Center Build | jetpack-installable-builds #5432 |
4 tasks
No other than reason than me looking at the CocoaPods setup and realizing we were a few versions behind.
Despite it working during the prototype stage, I wasn't able to get the XCFrameworks out of the ZIP archive, but it works fine with the tar.gz. I suspect this has to do with the folder(s) generated when decompressing.
These are unnecessary at the moment but will be when we move to Gutenberg via XCFramework
The advantage of this approach is that downloading the archive is only necessary when using a local spec. Defining the logic in the local spec itself keeps everything self contained and saves us from having to conditionally call the `pre_install` hook.
The idea was to use a local spec and interpolated the desired commit SHA1 in the `source` to download the corresponding `tar.gz`. However, CocoaPods has some issues with local specs that use `http` `source`, as documented in: - CocoaPods/CocoaPods#10288 (comment) - https://github.com/firebase/firebase-ios-sdk/blob/68b39b8edf61f6e643e2396e712c7c67e0f146ff/scripts/pod_lib_lint.rb#L70-L78 Using a remote spec doesn't have the same issue, and the cost in terms of extra computation and storage is negligible when compared to building and hosting the `tar.gz` archives.
This was done to address the following CI failure when building with the Gutenberg XCFramework: ``` ▸ Linking WordPress⚠️ ld: Could not find or use auto-linked library 'swiftCompatibility56' ❌ ld: symbol(s) not found for architecture x86_64 ``` https://buildkite.com/automattic/wordpress-ios/builds/14356#01885545-c05a-43a8-b475-d0d683857672
Because the latest XCFramework setup ships without testing compilation.
Co-authored-by: Tony Li <[email protected]>
Co-authored-by: Tony Li <[email protected]>
mokagio
force-pushed
the
test/xcframework-different-hermes-setup
branch
from
f8dafcf to
1aebf8d
Compare
The problem has to do with `trunk` using 1.100.0-alpha.1 but the build this is based on being on an earlier version.
4 tasks
mokagio
changed the base branch from
mokagio/gutenberg-xcframework-setup
to
gutenberg/tweak-pod-deps-by-rn-version
|
No longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different setup than the one from #21021.
It's currently incomplete because of the huge resulting size of the app, see details in wordpress-mobile/gutenberg-mobile#5973.