-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Upgrade React Native 0.71.11
#20956
Merged
Merged
Changes from 52 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
b7fd735
Add a local `podspec` to download Gutenberg XCFramework commit builds
mokagio 27e6b3f
Add check to fail `pod install` if Gutenberg ZIP doesn't exist at URL
mokagio 22334c5
Use latest CocoaPods version
mokagio aca165e
Switch to tar.gz for the Gutenberg XCFramework archive
mokagio 211b497
Use same license as the main project for the Gutenberg pod
mokagio 0aa0487
Work around CP not finding XCFrameworks by downloading manually
mokagio dffeb71
Add a couple of newly required `import React`
mokagio 1acc425
Address new warnings introduced by the Gutenberg via XCFramework
mokagio 8176593
Update `CopyGutenbergJS` build phase script to account for XCFramework
mokagio 7d31186
Use relative paths when importing the local Gutenberg podspec
mokagio 27186a2
Remove `pre_install` download hook in favor of `prepare_command`
mokagio a4c6070
Use remote spec instead of a local one for Gutenberg via commit
mokagio 11b0d2c
Update Gutenberg `tar.gz` URL after changes in gutenberg-mobile
mokagio 64ac588
Use Xcode 14.3.1
mokagio ede6c5d
Update Gutenberg CP setup to use XCFrameworks when referenced via tag
mokagio 0806f9b
Switch to Gutenberg v1.98.1 installed as an XCFramework
mokagio dfae970
Do not `@testable import` Gutenberg in unit tests
mokagio 4726973
DRY logic setting Gutenberg URL when using tag or commit
mokagio c2c46cc
Simplify `gutenberg_dependencies` with early return
mokagio 59d7b78
Update Gutenberg local setup to work with React Native 0.71.11
mokagio d03be58
Add calls to RN hooks when using Gutenberg from local path
mokagio 3fcd1b5
Update build script to run locally without a Gutenberg `App.js`
mokagio b6b8d9c
Shrink inline comment of `gutenberg_post_install` helper
fluiddot d6dd34e
Update `Podfile.lock` file
fluiddot d81f466
Add build phase to prevent nested frameworks
mokagio f875968
Remove outdated Xcode 12.5 mention from nested frameworks linter
mokagio 9192af0
Merge branch 'trunk' into mokagio/gutenberg-xcframework-setup
fluiddot 381d49a
Update RNReanimated pod source to `wp-fork-2.17.0`
fluiddot ebd4cca
Add `gutenberg_local_pod` helper
fluiddot 2b1138f
Tweak pod dependencies based on the React Native version
fluiddot 65e5454
Merge and fix pre-install logic into `gutenberg_dependencies` block
fluiddot 2d40a68
Fix typo in post install hook
fluiddot 598b038
Move RNReanimated dependency workaround to a separate function
fluiddot 341f617
Fetch React Native version using JSON lib
fluiddot 551968e
Update Gutenberg Mobile ref to use workaround for Hermes framework
fluiddot 723f8ed
Reintroduce link to internal doc with "Do Not Embed" explanation
mokagio 9ceb947
Use CI toolkit version 2.18.1 for better failure annotations
mokagio e39537b
Add build phase to detect nested frameworks (#21130)
mokagio 4530832
Add workaround for editor UI tests failing with keyboard not available
mokagio 170d7f4
Merge pull request #21143 from wordpress-mobile/test/latest-wip-xcfra…
fluiddot a4fe6e8
Update Gutenberg Mobile ref
fluiddot d7cf5c3
Update release notes
fluiddot 4945d03
Merge branch 'trunk' into gutenberg/upgrade/react-native-0.71.11
fluiddot 795a9c2
Merge remote-tracking branch 'origin/trunk' into gutenberg/upgrade/re…
mokagio 64811c6
Merge branch 'mokagio/gutenberg-xcframework-setup' into gutenberg/upg…
fluiddot c992bcb
Remove adding `React-jsc` Pod
fluiddot 7e11b1e
Remove inline comment about error explanation
fluiddot 6ce7fdc
Update Gutenberg Mobile ref
fluiddot 59b6bb3
Fix typo in `CopyGutenbergJS.sh` script
fluiddot 8c8f945
Merge branch 'trunk' into gutenberg/upgrade/react-native-0.71.11
fluiddot e39dfaf
Merge branch 'trunk' of github.com:wordpress-mobile/WordPress-iOS int…
dcalhoun 12164fc
build: Update Gutenberg version
dcalhoun 4642cfb
Re-introduce Gutenberg pod to remove duplicated sources in `Podfile.l…
fluiddot 131057d
Re-introduce `SDWebImage` pod
fluiddot 812b034
Merge branch 'trunk' into gutenberg/upgrade/react-native-0.71.11
fluiddot 40541ae
Update release notes
fluiddot 66ad340
Update Gutenberg Mobile ref with tag
fluiddot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These conditions will never be met as
gutenberg_dependencies
is only called when using Gutenberg locally, i.e. it will always reference the pod using a path.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it makes sense to keep it in case
gutenberg_dependencies
is used somewhere else in the future 🤔.